Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an extra resource capability to tenant chart #1642

Closed
IxDay opened this issue Jun 15, 2023 · 0 comments · Fixed by #1643
Closed

Add an extra resource capability to tenant chart #1642

IxDay opened this issue Jun 15, 2023 · 0 comments · Fixed by #1643
Labels
community

Comments

@IxDay
Copy link
Contributor

IxDay commented Jun 15, 2023

Is your feature request related to a problem? Please describe.
When deploying the minio tenant chart I also need to deploy some extra resources (because of some additional controllers and CRDS I have in my cluster).

Describe the solution you'd like
The same way bitnami charts has an extra resources/deployments, I'd like to have an entry in the values files to generate extra resources. It renders YAML template as part of the chart and it can take advantage of the helper functions (so I have consistent labels, naming). This remove also the need for the chart to support some corner cases CRDs since anyone can inject what they need.

Describe alternatives you've considered
I could use a chart dependency, however, this brings additional complexity and also prevents me from using the chart helpers which can be helpful to generate consistent naming.
IxDay added a commit to IxDay/operator that referenced this issue Jun 15, 2023
@IxDay
Tenant chart: : add extra resources capability
0b47b62 
This commit introduces an extraResources value which is directly
rendered as part of the chart like a regular Helm template.
This allows users to add some Kubernetes object they might need as part
of their cluster configuration.
I added in the comment an example of my use case because I use a
different type of ingress and it is easier to configure it this way.

Closes: minio#1642
@IxDay IxDay mentioned this issue Jun 15, 2023
Merged
pjuarezd added a commit that referenced this issue Jun 27, 2023
@IxDay @pjuarezd
Tenant chart: : add extra resources capability (#1643)
c737cd0 
This commit introduces an extraResources value which is directly
rendered as part of the chart like a regular Helm template.
This allows users to add some Kubernetes object they might need as part
of their cluster configuration.
I added in the comment an example of my use case because I use a
different type of ingress and it is easier to configure it this way.

Closes: #1642

Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tenant chart: : add extra resources capability IxDay/operator
2 participants
@IxDay @allanrogerr