To fix "Logs test on Kind" test by attempting more than one time getting the API response. #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
changed the title
cniackz
requested review from
harshavardhana,
dvaldivia,
adfost,
Alevsk,
bexsoft,
jinapurapu,
kaankabalak and
prakashsvmx
cniackz
changed the title
harshavardhana
approved these changes
Feb 7, 2022
Alevsk
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team,
Long story short, after changes in PR 989: operator:v4.4.4 tests become bit more inestable.
Nevertheless, when tested manually, noticed that Prometheus and Logs API were both reachable if we
attempted couple of times to get the response. The intention of this test, is to make these tests more
stable by adding a loop to re-try getting the answer from API until this is obtained as before.
Notice that previously, we just attempted this once.
Please give me feedback and if we should proceed this way or if you have any other idea,
I am happy to try other experiment.
Thanks!