Removing credsSecret required field in tenant spec #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
force-pushed
the
remove-credssecret
branch
3 times, most recently
from
63af002 to
3e8f1fb
Compare
harshavardhana
requested changes
Feb 6, 2022
Alevsk
force-pushed
the
remove-credssecret
branch
2 times, most recently
from
836e5c5 to
0926ccd
Compare
harshavardhana
previously approved these changes
Feb 8, 2022
Alevsk
force-pushed
the
remove-credssecret
branch
from
0926ccd to
e47c4d0
Compare
Alevsk
force-pushed
the
remove-credssecret
branch
from
e47c4d0 to
0d45be6
Compare
harshavardhana
approved these changes
Mar 1, 2022
harshavardhana
requested changes
Mar 13, 2022
Alevsk
force-pushed
the
remove-credssecret
branch
from
0c39bc2 to
1c9740a
Compare
harshavardhana
previously approved these changes
Apr 5, 2022
harshavardhana
force-pushed
the
remove-credssecret
branch
from
1c9740a to
c2a4b0d
Compare
|
PTAL @Alevsk at conflicts |
|
Can we rebase this and take it in @Alevsk ? |
Working on this today @harshavardhana |
Alevsk
force-pushed
the
remove-credssecret
branch
from
c2a4b0d to
bb0720c
Compare
harshavardhana
requested changes
Jun 28, 2022
Alevsk
force-pushed
the
remove-credssecret
branch
from
bb0720c to
940b048
Compare
harshavardhana
previously approved these changes
Jun 28, 2022
Alevsk
force-pushed
the
remove-credssecret
branch
from
940b048 to
85be30b
Compare
harshavardhana
previously approved these changes
Jul 20, 2022
dvaldivia
approved these changes
Aug 25, 2022
dvaldivia
requested changes
Aug 25, 2022
There was a problem hiding this comment.
I'm hitting an NPE with a tenant which has no config file
goroutine 361 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0x4dd574})
k8s.io/apimachinery@v0.20.6/pkg/util/runtime/runtime.go:55 +0xd8
panic({0x16ad080, 0x2759220})
runtime/panic.go:1038 +0x215
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc000294250})
k8s.io/apimachinery@v0.20.6/pkg/util/runtime/runtime.go:55 +0xd8
panic({0x16ad080, 0x2759220})
runtime/panic.go:1038 +0x215
github.com/minio/operator/pkg/controller/cluster.(*Controller).checkForUpgrades(0xc000450480, {0x1af9218, 0xc000042028}, 0xc000e5f180)
github.com/minio/operator/pkg/controller/cluster/upgrades.go:93 +0xaca
github.com/minio/operator/pkg/controller/cluster.(*Controller).syncHandler(0xc000450480, {0xc001235bc0, 0x17})
github.com/minio/operator/pkg/controller/cluster/main-controller.go:650 +0x5ab
github.com/minio/operator/pkg/controller/cluster.(*Controller).processNextWorkItem.func1({0x163e060, 0xc000294250})
github.com/minio/operator/pkg/controller/cluster/main-controller.go:560 +0x245
github.com/minio/operator/pkg/controller/cluster.(*Controller).processNextWorkItem(0xc000450480)
github.com/minio/operator/pkg/controller/cluster/main-controller.go:572 +0x62
github.com/minio/operator/pkg/controller/cluster.(*Controller).runWorker(0x0)
github.com/minio/operator/pkg/controller/cluster/main-controller.go:512 +0x70
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x7fe77453cd60)
k8s.io/apimachinery@v0.20.6/pkg/util/wait/wait.go:155 +0x67
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc0003e90e0, {0x1acbfc0, 0xc0006f4e70}, 0x1, 0xc00008f620)
k8s.io/apimachinery@v0.20.6/pkg/util/wait/wait.go:156 +0xb6
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc000998520, 0x3b9aca00, 0x0, 0x28, 0xc0003e9140)
k8s.io/apimachinery@v0.20.6/pkg/util/wait/wait.go:133 +0x89
k8s.io/apimachinery/pkg/util/wait.Until(0xc000998590, 0xc0001c6480, 0xc00099c7e0)
k8s.io/apimachinery@v0.20.6/pkg/util/wait/wait.go:90 +0x25
created by github.com/minio/operator/pkg/controller/cluster.(*Controller).Start.func1
github.com/minio/operator/pkg/controller/cluster/main-controller.go:397 +0x3c5
Stream closed EOF for minio-operator/minio-operator-6f4f49887d-55pj4 (minio-operator)
85be30b to
6746eb6
Compare
If tenant has no config file we should throw an error and stop execution for that tenant, meaning if theres a version of that tenant already running thats fine, but we should not apply any new incoming changes, that sounds good? |
Alevsk
force-pushed
the
remove-credssecret
branch
3 times, most recently
from
13e954e to
eb372fc
Compare
Alevsk
force-pushed
the
remove-credssecret
branch
from
eb372fc to
4bd3b42
Compare
Alevsk
force-pushed
the
remove-credssecret
branch
2 times, most recently
from
49a5a93 to
aa5879a
Compare
- Removing required credsSecret field in tenant spec - Migration from creddsSecret to Configuration field for old tenants - Added helm lint verification to install_tenant test Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
Alevsk
force-pushed
the
remove-credssecret
branch
from
aa5879a to
bd32c2f
Compare
dvaldivia
approved these changes
Aug 30, 2022
|
Are we ready to make v5.0.0 @dvaldivia ? |
harshavardhana
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lenin Alevski alevsk.8772@gmail.com