Allow user to customize all tenant environment variables #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
May 20, 2022
Alevsk
force-pushed
the
custom-env-vars
branch
2 times, most recently
from
08c847a to
2e2d931
Compare
dvaldivia
approved these changes
May 21, 2022
harshavardhana
requested changes
May 21, 2022
- variables defined in `tenant.spec.env` will take precedence over default/hardcoded values - if a variable exists on the config.env configuration file operator will not pass it to the pods via container.spec.env Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
harshavardhana
force-pushed
the
custom-env-vars
branch
from
2e2d931 to
b657280
Compare
harshavardhana
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tenant.spec.envwill take precedence overdefault/hardcoded values
will not pass it to the pods via container.spec.env
Signed-off-by: Lenin Alevski alevsk.8772@gmail.com