Support for turning on/off logs #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivaj05
requested review from
harshavardhana,
adfost,
Alevsk,
bexsoft,
cniackz,
dvaldivia,
jinapurapu,
kaankabalak and
prakashsvmx
reivaj05
commented
Jun 1, 2022
| @@ -82,6 +82,12 @@ func newTenantCreateCmd(out io.Writer, errOut io.Writer) *cobra.Command { | |||
| f.StringVarP(&c.tenantOpts.ImagePullSecret, "image-pull-secret", "", "", "image pull secret to be used for pulling MinIO") | |||
| f.BoolVar(&c.tenantOpts.DisableAntiAffinity, "enable-host-sharing", false, "[TESTING-ONLY] disable anti-affinity to allow pods to be co-located on a single node (unsupported in production environment)") | |||
| f.StringVar(&c.tenantOpts.KmsSecret, "kes-config", "", "name of secret for KES KMS setup, refer https://github.com/minio/operator/blob/master/examples/kes-secret.yaml") | |||
| f.BoolVar(&c.tenantOpts.EnableAuditLogs, "enable-audit-logs", true, "Enable/Disable audit logs") | |||
There was a problem hiding this comment.
Operator UI has this enable by default but not sure if it should be the same behavior for kubectl
Alevsk
approved these changes
Jun 1, 2022
| }, | ||
| Resources: v1.ResourceRequirements{ | ||
| Requests: v1.ResourceList{ | ||
| v1.ResourceStorage: *resource.NewQuantity(diskSpace, resource.DecimalExponent), |
There was a problem hiding this comment.
Let's confirm this line first.
when deploying audit log via yamls operator will assign the storage using resource.BinarySI.
Ideally we should abstract the logic of the NewForLogDb function in https://github.com/minio/operator/blob/master/pkg/resources/statefulsets/log.go#L147 and use the same logic for both deployment types yamls and kubectl plugin
dvaldivia
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/miniohq/engineering/issues/857
This PR adds logic to kubectl-minio to turn on and off logs during tenant creation