Improvements for kubect-minio plugin #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
requested review from
harshavardhana,
Praveenrajmani,
klauspost,
cniackz,
dvaldivia,
kannappanr and
kanagarajkm
Alevsk
force-pushed
the
kubectl-plugin-tenant-configuration
branch
from
3911df1 to
ad8792b
Compare
dvaldivia
previously approved these changes
Jun 21, 2022
harshavardhana
requested changes
Jun 21, 2022
harshavardhana
requested changes
Jun 21, 2022
Alevsk
force-pushed
the
kubectl-plugin-tenant-configuration
branch
from
ad8792b to
7cbdfe7
Compare
harshavardhana
previously approved these changes
Jun 21, 2022
dvaldivia
previously approved these changes
Jun 21, 2022
klauspost
reviewed
Jun 21, 2022
- Use secure GenerateCredentials() function for tenants created via the krew plugin - Use configuration secret instead of credsSecret for tenants created via the krew plugin Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
Alevsk
force-pushed
the
kubectl-plugin-tenant-configuration
branch
from
b250897 to
091078c
Compare
harshavardhana
approved these changes
Jun 21, 2022
dvaldivia
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
krew plugin
via the krew plugin
Signed-off-by: Lenin Alevski alevsk.8772@gmail.com