Create tenant in interactive mode #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivaj05
commented
Aug 22, 2022
| cmd.MarkFlagRequired("servers") | ||
| cmd.MarkFlagRequired("volumes") | ||
| cmd.MarkFlagRequired("capacity") | ||
| cmd.MarkFlagRequired("namespace") |
There was a problem hiding this comment.
This will be now validated in TenantOptions.Validate, that way the new interactive flag can be processed and we can keep having these flags as required
|
Amazing, didn't know about this feature, tested locally, and liked already: $ ./kubectl-minio tenant create --interactive
Tenant name: cesar
Total of servers: 4
Total of volumes: 4
Namespace: cesar
Capacity: 1Gi
Disable TLS: y
Disable audit logs: y
Disable prometheus: y
Tenant 'cesar' created in 'cesar' Namespace
Username: AL6SP8P8BMCL1E1JHCHA
Password: OL5M5AE50Z8BjdHXO8zrVtsOEzcG3PaeF1XbEpuX
Note: Copy the credentials to a secure location. MinIO will not display these again.
APPLICATION SERVICE NAME NAMESPACE SERVICE TYPE SERVICE PORT
MinIO minio cesar ClusterIP 80
Console cesar-console cesar ClusterIP 9090
|
dvaldivia
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag to create and configure a new tenant in interactive mode
Closes: https://github.com/miniohq/engineering/issues/859