Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple client certificates #1263

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Aug 29, 2022

Add support for passing multiple client certificates via the
tenant.spec.externalClientCertSecrets field

Multiple client certificates will be mounted using the following folder
structure:

certs
  |
  + client-0
  |     + client.crt
  |     + client.key
  + client-1
  |     + client.crt
  |     + client.key
  + client-2
  |     + client.crt
  |     + client.key

Iterate over all provided client TLS certificates
and store them on the list of Volumes that will be
mounted to the Pod

Signed-off-by: Lenin Alevski alevsk.8772@gmail.com

Add support for passing multiple client certificates via the
`tenant.spec.externalClientCertSecrets` field

Multiple client certificates will be mounted using the following folder
structure:

```
certs
  |
  + client-0
  |     + client.crt
  |     + client.key
  + client-1
  |     + client.crt
  |     + client.key
  + client-2
  |     + client.crt
  |     + client.key
```

Iterate over all provided client TLS certificates
and store them on the list of Volumes that will be
mounted to the Pod

Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
@Alevsk Alevsk force-pushed the support-multiple-client-certs branch from 7d962a5 to 5a39414 Compare August 29, 2022 22:51
Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at least from a docs/explanation-side. This is a helpful feature!

@harshavardhana harshavardhana merged commit 2f58272 into minio:master Aug 30, 2022
@Alevsk Alevsk deleted the support-multiple-client-certs branch August 30, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants