[logsearch] Fix vacuuming to keep tables in sync #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
changed the title
donatello
force-pushed
the
vacuumer
branch
2 times, most recently
from
4cb2dfc to
b5aa208
Compare
- Ensure that child tables of each parent table corresponding to the same time period are deleted together. - Ensure that child tables corresponding the current time period are never deleted due to disk space. - Print a log when disk space cannot be recovered (i.e. when current tables are too large) indicating to increase available storage capacity.
|
PTAL @krisis |
harshavardhana
approved these changes
Sep 8, 2022
krisis
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that child tables of each parent table corresponding to the same time period are deleted together.
Ensure that child tables corresponding the current time period are never deleted due to disk space.
Print a log when disk space cannot be recovered (i.e. when current tables are too large) indicating to increase available storage capacity.