Add a startup probe #1284
Merged
Add a startup probe #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hrenard please rebase this with master? |
|
Done. |
harshavardhana
previously approved these changes
Sep 22, 2022
dilverse
requested changes
Sep 22, 2022
Signed-off-by: Hugo Renard <hugo.renard@protonmail.com>
dilverse
approved these changes
Sep 22, 2022
harshavardhana
approved these changes
Sep 22, 2022
Praveenrajmani
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address #600 and #947. The goal is to minimize errors or downtime during a rollout.
With a startup probe, k8s will wait for the server to be up before routing traffic to it and deleting another pod. Hopefully this will speed up the (re)connection to the cluster of fresh servers and avoid having too many servers down at the same time.
A potential issue could be if we want to make a critical change in the config which would require to restart all servers at almost the same time. But because upgrade is managed in-place, I believe a rollout don't require disturbing the cluster.
What do you think ?