Add flag for go template to format host names #130
Conversation
dmayle
force-pushed
the
template_host_name
branch
from
e17efd5 to
490dc4a
Compare
There was a problem hiding this comment.
Please update the documentation or add a new doc on how to use this feature @dmayle
dmayle
force-pushed
the
template_host_name
branch
2 times, most recently
from
de6d7c6 to
954b63c
Compare
|
I've updated the docs and merged in recent changes |
dmayle
force-pushed
the
template_host_name
branch
from
954b63c to
024937f
Compare
|
I can't seem to figure out how to mark that I've made the changes requested @harshavardhana |
There is no such thing in GitHub AFAIK @dmayle |
|
Code looks good any chance you can add a test for |
There was a problem hiding this comment.
@dmayle couple of comments
-
Custom template works fine in general, but breaks the automatics TLS configuration when
requestAutoCertis set to true. Can you pls addTemplatedMinIOHosts()in https://github.com/minio/minio-operator/blob/master/pkg/controller/cluster/csr.go#L70 as well. -
Operator is generally going to be run as a container, instead of a binary. So, it would be better if we add the example to pass
--hosts-templatein theminio-operator.yamlfile
dmayle
force-pushed
the
template_host_name
branch
from
63e5c4a to
2c6c483
Compare
|
@kerneltime added a test for the various template variables. |
dmayle
force-pushed
the
template_host_name
branch
from
2c6c483 to
35211f4
Compare
When using an alternate DNS like external-dns, your host names will be different than the internal core-dns format. This adds a flag so that the user can specify the name format using a go template.
dmayle
force-pushed
the
template_host_name
branch
from
35211f4 to
66ce518
Compare
This PR also fixes a regression introduced in #130 where incorrect arguements are passed to MinIO containers.
Update the install-tackle script to handle installing the konveyor operator using OLM via provided bundle image. With this, we should be able to test...at a minimum ... that our operator installs as part of PR checks. Fixes minio#130 Signed-off-by: David Zager <david.j.zager@gmail.com>
When using an alternate DNS like external-dns, your host names will be
different than the internal core-dns format. This adds a flag so that
the user can specify the name format using a go template.