-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new job to test Kubernetes 1.21 #1304
Conversation
Adding new job to test for the last supported version of kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question why on these k8s versions?
Hi @harshavardhana today while testing for the PR #1278 we identified the helm chart update doesn't work with Kubernetes 1.21 version but works with 1.25, since many of the customers still use 1.20 we wanted to ensure we didn't break anything in operator codebase. |
So should we simply deprecate helm chart for k8s v1.21 and older ? |
@harshavardhana after discussing this with Ab, we are going to keep the support for 1.20 around for a little longer, so we should take this in and delay the breaking changes to Helm until k8s 1.26 lands, then we can move our floor to 1.21 |
We should take this @harshavardhana since we are going to be adding support for container level Also with the release of |
Done bumped the version to 1.21.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Allan, please squash the commits from 4 to 1 and thank you
Why do we need to squash the commits? |
x2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok guys you are right, I haven't think that way but you are right, why do it twice 👍 |
Adding new job to test for the last supported version of kubernetes