Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new job to test Kubernetes 1.21 #1304

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Conversation

dilverse
Copy link
Member

Adding new job to test for the last supported version of kubernetes

Adding new job to test for the last supported version of kubernetes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question why on these k8s versions?

@dilverse
Copy link
Member Author

Hi @harshavardhana today while testing for the PR #1278 we identified the helm chart update doesn't work with Kubernetes 1.21 version but works with 1.25, since many of the customers still use 1.20 we wanted to ensure we didn't break anything in operator codebase.

@harshavardhana
Copy link
Member

Hi @harshavardhana today while testing for the PR #1278 we identified the helm chart update doesn't work with Kubernetes 1.21 version but works with 1.25, since many of the customers still use 1.20 we wanted to ensure we didn't break anything in operator codebase.

So should we simply deprecate helm chart for k8s v1.21 and older ?

@dvaldivia
Copy link
Collaborator

@harshavardhana after discussing this with Ab, we are going to keep the support for 1.20 around for a little longer, so we should take this in and delay the breaking changes to Helm until k8s 1.26 lands, then we can move our floor to 1.21

dvaldivia
dvaldivia previously approved these changes Dec 13, 2022
@dvaldivia
Copy link
Collaborator

We should take this @harshavardhana since we are going to be adding support for container level SecurityContext in a backwards compatible way, we need to make sure testing on our floor release is still working.

Also with the release of v1.26 we should make v1.21 the floor release @dilverse

@dilverse dilverse changed the title Add new job to test Kubernetes 1.20 Add new job to test Kubernetes 1.21 Dec 14, 2022
@dilverse
Copy link
Member Author

Done bumped the version to 1.21.14

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Allan, please squash the commits from 4 to 1 and thank you

@dilverse
Copy link
Member Author

Hello Allan, please squash the commits from 4 to 1 and thank you

Why do we need to squash the commits?
When the PR is getting merged its anyway going to squash and merge right?

@allanrogerr allanrogerr requested review from allanrogerr and removed request for Alevsk December 15, 2022 17:14
@reivaj05
Copy link
Contributor

Hello Allan, please squash the commits from 4 to 1 and thank you

Why do we need to squash the commits? When the PR is getting merged its anyway going to squash and merge right?

x2
I know it's a good practice but we are already doing it during merge... why do it twice and dismiss previous approvals?

@cniackz cniackz self-requested a review December 16, 2022 21:03
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz
Copy link
Contributor

cniackz commented Dec 16, 2022

Ok guys you are right, I haven't think that way but you are right, why do it twice 👍

@dvaldivia dvaldivia merged commit 687fcf1 into minio:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants