Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CONSOLE_POLICY key when create user #1359

Closed
wants to merge 1 commit into from

Conversation

drivebyer
Copy link
Contributor

@drivebyer drivebyer commented Dec 1, 2022

close #629

@dvaldivia
Copy link
Collaborator

I think this is a great idea in general as general improvement to the users being added, perhaps we should also add this to the list of users under .spec.users in which case each user can have a separate policy, would that be useful?

Else, my only feedback would be to rename the environment variable to something more aligned with the rest and that indicates this is the default policy, something like MINIO_OPERATOR_DEFAULT_USER_POLICY

@drivebyer
Copy link
Contributor Author

@dvaldivia thanks for you reply.

in which case each user can have a separate policy

For the PR, we can create different secret with different policy, So, I think the policy is already seprated for each user.

@drivebyer
Copy link
Contributor Author

Else, my only feedback would be to rename the environment variable to something more aligned with the rest and that indicates this is the default policy, something like MINIO_OPERATOR_DEFAULT_USER_POLICY

On my view, the CONSOLE_POLICY is more suitable, becouse it is consistent with CONSOLE_ACCESS_KEY and CONSOLE_SECRET_KEY

@dnskr
Copy link
Contributor

dnskr commented Dec 18, 2022

Else, my only feedback would be to rename the environment variable to something more aligned with the rest and that indicates this is the default policy, something like MINIO_OPERATOR_DEFAULT_USER_POLICY

On my view, the CONSOLE_POLICY is more suitable, becouse it is consistent with CONSOLE_ACCESS_KEY and CONSOLE_SECRET_KEY

Agree, CONSOLE_POLICY aligned with CONSOLE_ACCESS_KEY and CONSOLE_SECRET_KEY.
Would it be a good idea to use CONSOLE_POLICY for now, but deprecate CONSOLE_* names for ACCESS_KEY, SECRET_KEY and POLICY?

@drivebyer
Copy link
Contributor Author

Would it be a good idea to use CONSOLE_POLICY for now, but deprecate CONSOLE_* names for ACCESS_KEY, SECRET_KEY and POLICY?

Agree. The CONSOLE_ prefix confuse me a lot on first time.:)

@drivebyer drivebyer closed this Jan 30, 2023
@drivebyer drivebyer deleted the add_policy_field_for_user branch January 30, 2023 06:28
@jessebot
Copy link

jessebot commented Nov 12, 2023

what happened with this PR? Was there ever a new PR to follow up on it? I can help do this work if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create users with non-consoleAdmin policies during tenant provisioning
4 participants