-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart: Add priorityClass support for operator #1423
Conversation
the tests failing are not related to this PR changes, there is no harm in allow set a |
TestsAssign in Operator helm chart
Test deploy.Ensure file
Observe tenant pods for priority
Validate operator and tenants work as expected-- Create a priorty class
|
Works as expected @varet80 |
Thank you @allanrogerr, could you approve the PR please? |
{{- with .Values.operator.priorityClassName }} | ||
priorityClassName: {{ . }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For uniformity, I would suggest:
{{- with .Values.operator.priorityClassName }} | |
priorityClassName: {{ . }} | |
{{- end }} | |
{{- with .Values.operator.priorityClassName }} | |
priorityClassName: | |
{{- toYaml . | nindent 8 }} | |
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah!, same I though yesterday, but tried that and creates a carriage return that seems unecesary, ie:
priorityClassName:
prioriryClass
The current code outpus as follows, that is more natural.
priorityClassName: className
Add priorityClass support for operator helm chart
With the following change I am enabled the ability for the operator to be scheduled before minio clusters (if desired)
In case of restarts and or cases where required a full restart. We need operator to be scheduled before minio pods.
This way Pods can find the operator and startup properly.
priorityClass allows this more (https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/)