-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openshift test - install Minio Operator #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dvaldivia
approved these changes
Feb 9, 2023
pjuarezd
requested review from
allanrogerr,
dilverse,
donatello and
harshavardhana
February 14, 2023 00:04
cniackz
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pjuarezd
added a commit
to pjuarezd/operator
that referenced
this pull request
Mar 2, 2023
* test Operator install on Openshift using crc * moar debagging * openshift install test almost complete * some bugfixing, save checkpoint * Openshift operator install test Complete * bugfix: test was stuck, test catalogsource pod was unable to pull the container. * shellcheck * rename flag to sync with minio#1441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To test the install of
Minio Operator
in Openshift.This first iteration tests "community-operators" catalog, expecting to extend it to the other 2 catalogs (redhat-marketplace, certified-operators)
Reason:
We need to ensure that introduced changes to Operator do not break the Openshift deployment installs, at least fresh clean installs should be flawless.
Environment:
This test is by far not going to be able to be ran in a github action as to run
crc
expectos 20gb of ram and 12 cores.The test run expects that no install of
crc
orpodman
are present in the running host.!!WARNING:
The test downloads the binaries and creates a symlink of the
podman
command, if the running host already has apodman
binary in $PATH, it could be overwrited by the symlinkThe test considers the boot and delete of the crc virtual machine, make sure of backup your
~/.crc/cache
dir, OR setup the environment variableexport OPERATOR_ENABLE_MANUAL_TESTING=ON
to prevent the virtual machine deletion.The test breaks if
catalogsource
orsubscription
resources used by the test exists in the Openshift cluster, make sure to either delete them or backup yourcrc
vm and start with a freshcrc
vm on each test (prefered).How It looks: