-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Sidecar Args #1437
Introduce Sidecar Args #1437
Conversation
1fa7906
to
02f2b17
Compare
000af8c
to
7e1de79
Compare
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
17d1439
to
7dcc7ff
Compare
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Hello @dvaldivia I am starting to review and test this PR, I want to take my time to review this truly, so please merge PR if needed otherwise I will place my feedback soon! |
And because there is new Service Account, then we need extra line for the priviledged access in OpenShift:
Or have proper constraints for the security context, anyway, the important part is that Tenant can be deployed and initialized in OpenShift in this change: Also as a side note, used My next step is to keep exploring and test in k8s as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job @dvaldivia thanks for this big Change!!! 👍
Introduces an
initContainer
and asidecar
container for MinIO to retrieve theMINIO_ARGS
for the tenant and to monitor the configurations secret and update it locally as soon as it changes.Additional this sidecars will validate if root credentials are missing and if so, error out.