-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty securityContext #1462
Conversation
@cniackz I think there is a similar issue for Prometheus and its init container. operator/pkg/resources/statefulsets/prometheus.go Lines 207 to 214 in f6c9c8b
I.e. Prometheus cannot start on OpenShift, because initContainer[0].securityContext.runAsUser is 0 .
|
Thank you @dnskr but we are deprecating Prometheus for time being. We can open a separate PR for that if this feature comes back again. Or if I am mistaken we can have separate PR for it. For now, let's focus on the Tenant deployment in OpenShift at least. |
985e8d3
to
beff78f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Objective:
Avoid hardcoding values that are not part of any security context constraint and allow Tenant to be deployed without changing scc in OpenShift as Operator logic is currently not allowing empty securityContext for Tenant and this is totally wrong!.