Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applyconfiguration generated objects #1470

Merged
merged 2 commits into from
Feb 28, 2023
Merged

applyconfiguration generated objects #1470

merged 2 commits into from
Feb 28, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Feb 28, 2023 •
edited by cniackz
Loading

To fix: #1388

@pjuarezd pjuarezd mentioned this pull request Feb 28, 2023
Closed
@dvaldivia dvaldivia changed the title aplyconfiguration generated objects applyconfiguration generated objects Feb 28, 2023
@dvaldivia
Copy link
Collaborator

is this code generated automatically on release 0.27.0 or do we need any additional flags?

@pjuarezd
Copy link
Member Author

is this code generated automatically on release 0.27.0 or do we need any additional flags?

0.27.0-alpha.2, no additional flag, the "all" flag is enough to include the applyconfiguration objects in this version.

operator/k8s/update-codegen.sh

Line 43 in 6c2cb23

${CODEGEN_PKG}/generate-groups.sh "all" \

@cniackz
Copy link
Contributor

cniackz commented Feb 28, 2023

test-kes failure is not associate with this change I think, so we can consider all tests as passing!

cniackz
cniackz approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job @pjuarezd thank you for the fix!

@pjuarezd pjuarezd merged commit ce78ffb into minio:master Feb 28, 2023
@pjuarezd pjuarezd deleted the k8s-applyconfiguration branch February 28, 2023 22:17
allanrogerr
allanrogerr reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally!

pjuarezd added a commit to pjuarezd/operator that referenced this pull request Mar 2, 2023
@pjuarezd
applyconfiguration generated objects (minio#1470)
32fbbcf 
* aplyconfiguration generated objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrogerr allanrogerr allanrogerr left review comments

@dvaldivia dvaldivia dvaldivia approved these changes

@cniackz cniackz cniackz approved these changes

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl minio tenant create --output's YAML is invalid
4 participants
@pjuarezd @dvaldivia @cniackz @allanrogerr