Improve the zone addition process #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
reviewed
Jun 19, 2020
Currently the operator deletes existing statefulset and creates a fresh new statefulset, during zone addition. This is not ideal because this requires a downtime of MinIO cluster. This PR attempts to improve this process by using the update statefulset API to add new pods and then deletes only the pods that were part of existing statefulset. As the pods are deleted Kubernetes spawns new pods. This means at any point, more than quorum number of MinIO pods are available. This allows a better, seamless zone addition flow. Also improve the minioinstance status update flow and cleanup KES flow in controller.
|
Ready for review, PTAL |
kerneltime
approved these changes
Jun 22, 2020
harshavardhana
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the operator deletes existing statefulset and creates a
fresh new statefulset, during zone addition. This is not ideal
because this requires a downtime of MinIO cluster.
This PR attempts to improve this process by using the update
statefulset API to add new pods and then deletes only the pods
that were part of existing statefulset. As the pods are deleted
Kubernetes spawns new pods. This means at any point, more than
quorum number of MinIO pods are available. This allows a better,
seamless zone addition flow.
Also improve the minioinstance status update flow and cleanup
KES flow in controller.