Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.0.0 #1520

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Release v5.0.0 #1520

merged 3 commits into from
Mar 27, 2023

Conversation

pjuarezd
Copy link
Member

Release 5.0.0
Signed-off-by: pjuarezd pjuarezd@users.noreply.github.com

@pjuarezd pjuarezd self-assigned this Mar 23, 2023
@dilverse
Copy link
Member

Looks like the operator v5.0.0 tag is not present so tests are failing unable to pull the image

@harshavardhana
Copy link
Member

Looks like the operator v5.0.0 tag is not present so tests are failing unable to pull the image

Shouldn't the tests be building them locally?

reivaj05
reivaj05 previously approved these changes Mar 24, 2023
View reviewed changes
cniackz
cniackz previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia
Copy link
Collaborator

@harshavardhana we build and tag minio/operator:noop and replace any image in the install/example kustomization files

@pjuarezd pjuarezd dismissed stale reviews from cniackz and reivaj05 via a690f4f March 26, 2023 23:41
@harshavardhana
Copy link
Member

@github-actions
Tenant Tests On Kind / test-policy-binding (1.20.x, ubuntu-latest) (pull_request) Failing after 13m

Can this failure be ignored? @pjuarezd @cesnietor @dvaldivia ?

@pjuarezd
Copy link
Member Author

@github-actions
Tenant Tests On Kind / test-policy-binding (1.20.x, ubuntu-latest) (pull_request) Failing after 13m

Can this failure be ignored? @pjuarezd @cesnietor @dvaldivia ?

mc admin policy add mc command changed to mc admin policy create, that broke the test, woking on fix it atm @harshavardhana

@pjuarezd
Release 5.0.0
f23a76b 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd added 2 commits March 27, 2023 00:51
@pjuarezd
Make kubernetes 1.21 minimal version
394a803
@pjuarezd
Fix tenant test
4dd0b0c 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
allanrogerr
allanrogerr approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 1f1d9d4 into minio:master Mar 27, 2023
@pjuarezd pjuarezd deleted the release-v5.0.0 branch March 28, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrogerr allanrogerr allanrogerr approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@bexsoft bexsoft Awaiting requested review from bexsoft

@dilverse dilverse Awaiting requested review from dilverse

@cniackz cniackz Awaiting requested review from cniackz

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pjuarezd @dilverse @harshavardhana @dvaldivia @cniackz @reivaj05 @allanrogerr