Stop tests to execute for hours when they are stuck #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
changed the title
cniackz
changed the title
cniackz
requested review from
dvaldivia,
pjuarezd,
harshavardhana,
reivaj05 and
allanrogerr
and removed request for
dvaldivia
pjuarezd
approved these changes
Mar 27, 2023
reivaj05
reviewed
Mar 27, 2023
| @@ -7,6 +7,7 @@ on: | |||
|
|
|||
| jobs: | |||
| goreleaser: | |||
| timeout-minutes: 30 | |||
There was a problem hiding this comment.
isn't 30 minutes too much time?
reivaj05
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To stop tests to run for hours when they are stuck
User Story:
I have seen lately that even setup go action can fail and last for hours, we shouldn't allow this to happen and instead stop those test after 30 minutes or so.
Evidence: