Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put under the MINIO_OPERATOR_RUNTIME the Openshit csr-signer addition #1551

Merged
merged 10 commits into from
Jul 14, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Apr 4, 2023

We will try to import the csr-singer secret and load the CA when the MINIO_OPERATOR_RUNTIME exists and is set to Openshift (case insensitive)

pjuarezd added 3 commits July 12, 2023 16:36
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd self-assigned this Jul 12, 2023
@pjuarezd pjuarezd requested review from cniackz, dvaldivia, harshavardhana, shtripat and jiuker and removed request for cniackz July 12, 2023 23:15
pkg/common/const.go Outdated Show resolved Hide resolved
pkg/controller/operator.go Show resolved Hide resolved
pjuarezd and others added 3 commits July 12, 2023 19:37
Co-authored-by: jiuker <2818723467@qq.com>
Co-authored-by: jiuker <2818723467@qq.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
jiuker
jiuker previously approved these changes Jul 13, 2023
pkg/utils/utils.go Outdated Show resolved Hide resolved
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
shtripat
shtripat previously approved these changes Jul 13, 2023
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/common/const.go Outdated Show resolved Hide resolved
Co-authored-by: jiuker <2818723467@qq.com>
@pjuarezd pjuarezd requested review from jiuker and shtripat July 13, 2023 16:21
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjuarezd pjuarezd merged commit 5a484fc into minio:master Jul 14, 2023
@pjuarezd pjuarezd deleted the flag-runtime branch July 14, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants