OLM: Conversion webhook is no longer needed

[cniackz]

Objective:

To deploy Operator v5.0.3 via OLM

Current Issue:

$ operator-sdk run bundle quay.io/cniackz4/minio-operator:v5.0.3 --index-image=quay.io/operator-framework/opm:v1.23.0
WARN[0004] quay.io/operator-framework/opm:v1.23.0 is a SQLite index image. SQLite based index images are being deprecated and will be removed in a future release, please migrate your catalogs to the new File-Based Catalog format 
INFO[0009] Created registry pod: quay-io-cniackz4-minio-operator-v5-0-3 
INFO[0009] Created CatalogSource: minio-operator-catalog 
INFO[0009] OperatorGroup "operator-sdk-og" created      
INFO[0009] Created Subscription: minio-operator-v5-0-3-sub 
INFO[0013] Approved InstallPlan install-t95vj for the Subscription: minio-operator-v5-0-3-sub 
INFO[0013] Waiting for ClusterServiceVersion "default/minio-operator.v5.0.3" to reach 'Succeeded' phase 
INFO[0013]   Waiting for ClusterServiceVersion "default/minio-operator.v5.0.3" to appear 
INFO[0024]   Found ClusterServiceVersion "default/minio-operator.v5.0.3" phase: Pending 
FATA[0120] Failed to run bundle: error waiting for CSV to install: timed out waiting for the condition 

Explanation:

We no longer have a spec.conversion.strategy got removed by Daniel when we deprecated tenant v1:
https://github.com/minio/operator/pull/1428/files#diff-19e1df82f13242efb9d69306d9f2933249a8559930041b3e3ad2f0bfe6f0e365L13

Hence we are facing this issue while deploying in Catalogs:

err="the bundle cannot be deployed because deployment validation has failed: [
	{

		Name:tenants.minio.min.io Errors:[

			Error: Field spec.conversion.strategy, 
			Value : spec.conversion.strategy: 
			Required value Error: Field spec.conversion.webhookClientConfig, 
			Value : spec.conversion.webhookClientConfig: 
			Forbidden: should not be set when strategy is not set to Webhook
		] 

		Warnings:[]

	}
]" 

Solution:

The solution is simple, remove webhook for now. We can add it back when v3 comes up.

Tested Locally:

$ operator-sdk run bundle quay.io/cniackz4/minio-operator:v5.0.3 --index-image=quay.io/operator-framework/opm:v1.23.0
WARN[0037] quay.io/operator-framework/opm:v1.23.0 is a SQLite index image. SQLite based index images are being deprecated and will be removed in a future release, please migrate your catalogs to the new File-Based Catalog format 
INFO[0043] Created registry pod: quay-io-cniackz4-minio-operator-v5-0-3 
INFO[0043] Created CatalogSource: minio-operator-catalog 
INFO[0043] OperatorGroup "operator-sdk-og" created      
INFO[0043] Created Subscription: minio-operator-v5-0-3-sub 
INFO[0047] Approved InstallPlan install-fvvvs for the Subscription: minio-operator-v5-0-3-sub 
INFO[0047] Waiting for ClusterServiceVersion "default/minio-operator.v5.0.3" to reach 'Succeeded' phase 
INFO[0047]   Waiting for ClusterServiceVersion "default/minio-operator.v5.0.3" to appear 
INFO[0070]   Found ClusterServiceVersion "default/minio-operator.v5.0.3" phase: Pending 
INFO[0073]   Found ClusterServiceVersion "default/minio-operator.v5.0.3" phase: Installing 
INFO[0082]   Found ClusterServiceVersion "default/minio-operator.v5.0.3" phase: Succeeded 
INFO[0082] OLM has successfully installed "minio-operator.v5.0.3" 

[shtripat]

lgtm