Warn user about the proper use of subPath field #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
be-consistent-across-the-repo-for-subpath
branch
from
24097e4 to
cf5e150
Compare
cniackz
force-pushed
the
be-consistent-across-the-repo-for-subpath
branch
from
cf5e150 to
1d00810
Compare
cniackz
changed the title
harshavardhana
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Avoid having two
.minio.sysfiles under the samePVas already observed with one of our customers.Reasoning:
In https://github.com/minio/operator/blob/master/examples/kustomization/base/tenant.yaml#L149 we are using
subPath: "":but in Helm we introduced
/databack in #526 then if a user install the tenant via Kustomize and then remove just the tenant and put it back using helm, will end up with a new Tenant with same name and same namespace but two.minio.sysfiles under the same PV. Then user will think buckets are gone when in fact they are still in the PV just in different path. To avoid this confusion we can warn user about the proper use of this field.