Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: krew plugin not assigning pool name #1612

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: krew plugin not assigning pool name #1612

merged 1 commit into from
May 23, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented May 23, 2023 •
edited
Loading

What this do

  • kubectl minio tenant expand Setting a default name to the new pool when no explicit name is assigned
  • Add make target plugin-binary to build krew plugin locally

Related to #1613

how to test

  1. Rebuild kubectl krew command
make -B "plugin-binary"
  1. install plugin
cp kubectl-minio/kubectl-minio ~/.krew/bin/kubectl-minio-dev
  1. expand tenant with plugin, do not assign a name to the pool
kubectl-minio-dev tenant expand minio-tenant-1 -n minio-tenant-1 --servers 3 --storage-class standard --volumes 6 --capacity 16Gi

Expanding Tenant 'minio-tenant-1/minio-tenant-1' from 1.0 TiB to 1.0 TiB
  1. should list the new pool in Operator console

list new pool

@pjuarezd
kubectl minio tenant expand Setting a default name to the new pool …
45409f6 
…when no explicit name is assigned

Add make target to build krew plugin locally

Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd self-assigned this May 23, 2023
@pjuarezd pjuarezd added the bug Something isn't working label May 23, 2023
@pjuarezd pjuarezd changed the title fix: krew pluggin not assigning pool name fix: krew plugin not assigning pool name May 23, 2023
@dilverse dilverse merged commit a524d92 into minio:master May 23, 2023
@pjuarezd pjuarezd deleted the kubectl-minio-missing-pool-name branch May 23, 2023 22:27
@cniackz cniackz mentioned this pull request Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilverse dilverse dilverse approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@reivaj05 reivaj05 Awaiting requested review from reivaj05

@cesnietor cesnietor Awaiting requested review from cesnietor

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@bexsoft bexsoft Awaiting requested review from bexsoft

Assignees

@pjuarezd pjuarezd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjuarezd @dvaldivia @dilverse