-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:check pool name before add #1628
Conversation
Hello @jiuker How can I test this PR?... I tested locally with these changes, but when I add duplicated pool by editing the tenant spec, I can add it and I don't see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this change based on the code review; but I am having troubles to understand how this can be tested. I will talk to Jiuker directly to learn from him the testing steps and document.
check pool name before add
related #1626