Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat chart templates with minor property fixes #1647

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Reformat chart templates with minor property fixes #1647

merged 5 commits into from
Jun 27, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Jun 18, 2023

Description

The PR reformats chart templates to common more compact and readable style.
The PR also includes a few minor property fixes.

Details

Similar reformatting changes: minio/minio#16947 apache/superset#23681

Operator template fixes:

  • Console deployment used operator.imagePullSecrets property
  • Console deployment used operator.runtimeClassName property
  • Console container used operator.image.pullPolicy property

Operator values.yaml:

  • Declare missing runtimeClassName and env properties
  • Fix initcontainers property name

@shtripat shtripat requested review from pjuarezd and dvaldivia June 23, 2023 03:37
@dnskr
Copy link
Contributor Author

dnskr commented Jun 27, 2023

@harshavardhana Merge conflict resolved.

@harshavardhana
Copy link
Member

PTAL @pjuarezd

@pjuarezd pjuarezd merged commit 40465cb into minio:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnskr @harshavardhana @pjuarezd