-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: speedup event sync upon error #1662
Merged
harshavardhana
merged 8 commits into
minio:master
from
jiuker:speedup_sync_error_time_interval
Jun 27, 2023
Merged
fix: speedup event sync upon error #1662
harshavardhana
merged 8 commits into
minio:master
from
jiuker:speedup_sync_error_time_interval
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before: it take 4 min to create User success.
after:
|
harshavardhana
approved these changes
Jun 27, 2023
pjuarezd
approved these changes
Jun 27, 2023
harshavardhana
changed the title
speedup sync error occurs
fix: speedup event sync upon error
Jun 27, 2023
'UsersCreatedFailed' Users creation failed: The difference between the request time and the server's time is too large |
@csdnak This doesn't seem to be related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speedup sync error occurs
https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/internal/controller/controller.go
When there is a processing error, the next event processing will be 1 minute later.