Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont create default secret if existingSecret value set #1663

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Dont create default secret if existingSecret value set #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aafb2b
Dont create default secret if `existingSecret` value set
shtripat Jun 27, 2023
bcd0170
Merge branch 'master' into dont-create-env-conf-by-default
harshavardhana Jun 27, 2023
22da193
Merge branch 'master' into dont-create-env-conf-by-default
pjuarezd Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/tenant/templates/tenant-configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if dig "secrets" false (.Values | merge (dict)) }}
{{- if not .Values.secrets.existingSecret }}
apiVersion: v1
kind: Secret
metadata:
Expand Down
2 changes: 2 additions & 0 deletions helm/tenant/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ secrets:
# MinIO root user and password
accessKey: minio
secretKey: minio123
## Set the value for existingSecret to use a pre created secret and dont create default one
# existingSecret: random-env-configuration
## MinIO Tenant Definition
tenant:
# Tenant name
Expand Down