Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force flag to minio delete command #1687

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Add --force flag to minio delete command #1687

merged 9 commits into from
Jul 25, 2023

Conversation

r-scheele
Copy link
Contributor

@r-scheele r-scheele commented Jul 15, 2023

Objective:

To delete the operator with a flag

Additional Information:

This pr is based on the issue here

how to test

  1. Rebuild kubectl krew command
make -B "plugin-binary"
  1. install plugin
cp kubectl-minio/kubectl-minio ~/.krew/bin/kubectl-minio-dev
  1. expand tenant with plugin, do not assign a name to the pool
kubectl-minio-dev delete --force --dangerous

namespace "minio-operator" deleted
serviceaccount "minio-operator" deleted
clusterrole.rbac.authorization.k8s.io "minio-operator-role" deleted
clusterrolebinding.rbac.authorization.k8s.io "minio-operator-binding" deleted
customresourcedefinition.apiextensions.k8s.io "tenants.minio.min.io" deleted
customresourcedefinition.apiextensions.k8s.io "policybindings.sts.min.io" deleted
service "operator" deleted
service "sts" deleted
deployment.apps "minio-operator" deleted
serviceaccount "console-sa" deleted
clusterrole.rbac.authorization.k8s.io "console-sa-role" deleted
clusterrolebinding.rbac.authorization.k8s.io "console-sa-binding" deleted
configmap "console-env" deleted
service "console" deleted
deployment.apps "console" deleted

@r-scheele r-scheele requested a review from cniackz July 15, 2023 05:24
kubectl-minio/cmd/delete.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/delete.go Show resolved Hide resolved
@cniackz
Copy link
Contributor

cniackz commented Jul 19, 2023

@r-scheele please address the last change requested by @harshavardhana and make sure to test this truly and if possible post the testing results on your PR.

Thank you very much! 👍

@r-scheele
Copy link
Contributor Author

r-scheele commented Jul 19, 2023

@r-scheele please address the last change requested by @harshavardhana and make sure to test this truly and if possible post the testing results on your PR.

Thank you very much! 👍

Hi @cniackz, @harshavardhana, can you check the pr description now?

pjuarezd added 3 commits July 25, 2023 10:48
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd merged commit 41ac8de into minio:master Jul 25, 2023
@pjuarezd
Copy link
Member

Closes #1683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants