Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic secrets configuration for root #1693

Closed
wants to merge 12 commits into from
Closed

Conversation

D1StrX
Copy link

@D1StrX D1StrX commented Jul 20, 2023

Removed configuration.name. Changed to dynamic reference of secrets.name or secrets.existingSecret

@D1StrX D1StrX mentioned this pull request Jul 20, 2023
helm/tenant/templates/tenant.yaml Outdated Show resolved Hide resolved
helm/tenant/templates/tenant.yaml Outdated Show resolved Hide resolved
helm/tenant/templates/tenant.yaml Outdated Show resolved Hide resolved
@D1StrX D1StrX requested a review from jiuker August 1, 2023 18:42
@jiuker
Copy link
Contributor

jiuker commented Oct 7, 2023

@D1StrX Could you resolve the conflicts?

@D1StrX
Copy link
Author

D1StrX commented Oct 7, 2023

@D1StrX Could you resolve the conflicts?

I have done that a while ago, am I missing something?

@harshavardhana
Copy link
Member

@D1StrX Could you resolve the conflicts?

I have done that a while ago, am I missing something?

You need to do that again.

helm/tenant/values.yaml Outdated Show resolved Hide resolved
D1StrX added 3 commits October 8, 2023 11:29
…alues. Bucket creation, user creation and some basic env testing works.
helm/tenant/values.yaml Show resolved Hide resolved
@D1StrX
Copy link
Author

D1StrX commented Oct 10, 2023

All change requests are resolved correct?

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@cniackz cniackz self-assigned this Apr 20, 2024
@stale stale bot removed the stale label Apr 20, 2024
@cniackz
Copy link
Contributor

cniackz commented Apr 20, 2024

it has not had recent activity

@cniackz cniackz closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants