Bugfix reload CA cert in operator-ca-tls secret
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjuarezd
requested review from
harshavardhana,
shtripat,
cesnietor,
jiuker and
dvaldivia
pjuarezd
changed the title
operator-ca-tls secret
jiuker
requested changes
Aug 9, 2023
|
This PR needs slices library released in go 1.21, once this PR #1718 is merged it should pass tests |
pjuarezd
force-pushed
the
bugfix-reload-operator-ca-tls-after-update
branch
from
fe69c09 to
ca465c4
Compare
When the CA certificate in the secret `operator-ca-tls` changes, Operator recreates this secret on the Tenants namespace, but is not using the newly provided cert for healthcheck, this will force reload the certificates on secret update
pjuarezd
force-pushed
the
bugfix-reload-operator-ca-tls-after-update
branch
from
ca465c4 to
735dbfa
Compare
harshavardhana
previously approved these changes
Aug 10, 2023
|
PTAL @cesnietor @cniackz @dvaldivia |
cesnietor
reviewed
Aug 10, 2023
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
cesnietor
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CA certificate in the secret
operator-ca-tlschanges, Operator recreates this secret on the Tenants namespace, but is not using the newly provided cert for healthcheck, a manual operator deployment restart is required.This fix will force reload the certificates on secret update.