Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:minio operator should not use a fixed name while deployment. #1762

Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 8, 2023

Now we will get deployment by a fixed name minio-operator. We should get it from env first.

// getOperatorDeploymentName Internal func returns the Operator deployment name from MINIO_OPERATOR_DEPLOYMENT_NAME ENV variable or the default name
func getOperatorDeploymentName() string {
	return env.Get(OperatorDeploymentNameEnv, DefaultDeploymentName)
}

@jiuker jiuker requested review from harshavardhana, pjuarezd, dvaldivia and shtripat and removed request for harshavardhana and pjuarezd September 8, 2023 06:23
harshavardhana
harshavardhana previously approved these changes Sep 8, 2023
@shtripat shtripat changed the title fix:minio operator should not use a fixed name to get itself deployment. fix:minio operator should not use a fixed name while deployment. Sep 8, 2023
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 2f9b7b6 into minio:master Sep 8, 2023
24 checks passed
@bh4t bh4t added the bug fix label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants