Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:plugin version will show the operator's version #1781

Merged
merged 2 commits into from
Oct 7, 2023
Merged

feat:plugin version will show the operator's version #1781

merged 2 commits into from
Oct 7, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 18, 2023 •
edited
Loading

For now:
Just the version come out:
v5.0.9 for example.
For this pr, will show like:

Kubectl-Plugin Version: DEVELOPMENT.GOGET
Minio-Operator Console Version: minio-system/console:v5.0.6 
Minio-Operator Controller Version: minio-system/minio-operator:v5.0.6

test steps:

  1. go build -o k
  2. ./k version --kubeconfig="yourkubeconfig"

shtripat
shtripat reviewed Sep 18, 2023
View reviewed changes
kubectl-minio/cmd/version.go Show resolved Hide resolved
kubectl-minio/cmd/version.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from shtripat September 19, 2023 02:07
@harshavardhana harshavardhana merged commit dbdf9d7 into minio:master Oct 7, 2023
24 checks passed
@bh4t bh4t added the enhancement New feature or request label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@shtripat shtripat Awaiting requested review from shtripat

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiuker @harshavardhana @pjuarezd @shtripat @bh4t