Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Volumes Support for Tenant Helm Chart #1786

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Additional Volumes Support for Tenant Helm Chart #1786

merged 1 commit into from
Oct 16, 2023

Conversation

pschichtel
Copy link
Contributor

@pschichtel pschichtel commented Sep 22, 2023 •
edited
Loading

This small change introduces support for the additionalVolumes and additionalVolumeMounts fields of the tenant CR to the helm chart. My intention is to use this to configure MINIO_KMS_SECRET_KEY_FILE instead of having the secret in an env var directly.

The second commit also enables encryption if MINIO_KMS_SECRET_KEY_FILE is passed and not just when MINIO_KMS_SECRET_KEY is passed. If necessary I can split that change into a separate PR. See: #1789

jiuker
jiuker requested changes Sep 25, 2023
View reviewed changes
api/tenant-get-handlers.go Outdated Show resolved Hide resolved
@pschichtel pschichtel mentioned this pull request Sep 25, 2023
Merged
@pschichtel
Copy link
Contributor Author

@jiuker @pjuarezd @cniackz not sure what the process is here. is something missing or is this just in some kind of review queue waiting to be reviewed?

@jiuker
Copy link
Contributor

jiuker commented Oct 9, 2023 •
edited
Loading

@jiuker @pjuarezd @cniackz not sure what the process is here. is something missing or is this just in some kind of review queue waiting to be reviewed?

Waiting to be reviewed. We will handle this.

@harshavardhana harshavardhana merged commit 9c20d54 into minio:master Oct 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiuker jiuker jiuker approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pschichtel @jiuker @harshavardhana