Support k8s secrets in console pod #1800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #1439
Explanation:
In the certificate path we only look for
public.crt
andprivate.key
to serve console in 9443. But in k8s we have other type of secrets with different file names likecert-manager
secrets ork8s
secrets, hence we should also supporttls.crt
andtls.key
to allow people to usecert-manager
or other methods not just our self-signed cert.How to test:
k proxy
How it looks:
$ pwd /Users/cniackz/.console/certs
Expected: