Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To ignore the creationTimestamp unknown field when performing tenant upgrade #1825

Merged
merged 1 commit into from
Oct 19, 2023
Merged

To ignore the creationTimestamp unknown field when performing tenant upgrade #1825

merged 1 commit into from
Oct 19, 2023

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Oct 19, 2023 •
edited
Loading

How to test:

  1. checkout PR
  2. build binary
  3. ./kubectl-minio/kubectl-minio tenant upgrade minio-tenant-1 --image minio/minio:RELEASE.2023-10-16T04-13-43Z
Upgrade is a one way process. Are you sure to upgrade Tenant 'minio-tenant-1/minio-tenant-1' from version minio/minio:RELEASE.2023-10-16T04-13-43Z to minio/minio:RELEASE.2023-10-16T04-13-43Z: y
Upgrade is a one way process. Are you sure to upgrade Tenant 'minio-tenant-1/minio-tenant-1' from version minio/minio:RELEASE.2023-10-16T04-13-43Z to minio/minio:RELEASE.2023-10-16T04-13-43Z: y

Upgrading Tenant 'minio-tenant-1/minio-tenant-1'

Closes 1778

@pjuarezd
To ignore the creationTimestamp unknown field when performing tenant …
7e544b4 
…upgrade

Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd self-assigned this Oct 19, 2023
shtripat
shtripat approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified, the warning message doesn't get shown now.

@pjuarezd pjuarezd merged commit d1dac6d into minio:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

@jiuker jiuker jiuker approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@cesnietor cesnietor Awaiting requested review from cesnietor

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unknown field "spec.pools[0].volumeClaimTemplate.metadata.creationTimestamp" when trying to upgrade a tenant
4 participants
@pjuarezd @harshavardhana @shtripat @jiuker