-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tenant CRD with multi Statefulset Support #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bfc5ee
to
ea7721a
Compare
kerneltime
reviewed
Jul 22, 2020
kerneltime
reviewed
Jul 22, 2020
kerneltime
reviewed
Jul 22, 2020
kerneltime
previously approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very manageable! Excellent!
Left some minor nits, lets get this in to start more testing :-)
kerneltime
reviewed
Jul 22, 2020
kerneltime
reviewed
Jul 22, 2020
nitisht
suggested changes
Jul 22, 2020
With zone setup as this zones:
- servers: 4
volumesPerServer: 2
volumeClaimTemplate:
metadata:
name: data
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 1Ti
- servers: 4
volumesPerServer: 4
volumeClaimTemplate:
metadata:
name: data
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 1Ti Operator creates incorrect command line args
It should be
|
Patching an existing Tenant did not add new statefulset / pods |
@nitisht both issues are fixed now |
9205d7d
to
248e9de
Compare
harshavardhana
approved these changes
Jul 22, 2020
nitisht
approved these changes
Jul 23, 2020
jmontleon
added a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Tenant CRD which supports multiple statefulsets, one per-zone.
Introduces new validations
A folder called
testing
is included. This folder includes a variety of yamls with tenants that will fail validations or tests a specific configuration.