Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tenant CRD with multi Statefulset Support #183

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Jul 22, 2020

Updated Tenant CRD which supports multiple statefulsets, one per-zone.
Introduces new validations
A folder called testing is included. This folder includes a variety of yamls with tenants that will fail validations or tests a specific configuration.

Screen Shot 2020-07-21 at 4 56 18 PM

kerneltime
kerneltime previously approved these changes Jul 22, 2020
Copy link
Contributor

@kerneltime kerneltime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very manageable! Excellent!
Left some minor nits, lets get this in to start more testing :-)

hack/update-codegen.sh Outdated Show resolved Hide resolved
pkg/controller/cluster/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/cluster/main-controller.go Show resolved Hide resolved
pkg/resources/statefulsets/minio-statefulset.go Outdated Show resolved Hide resolved
@nitisht
Copy link
Contributor

nitisht commented Jul 22, 2020

With zone setup as this

zones:
    - servers: 4
      volumesPerServer: 2
      volumeClaimTemplate:
        metadata:
          name: data
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 1Ti
    - servers: 4
      volumesPerServer: 4
      volumeClaimTemplate:
        metadata:
          name: data
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 1Ti

Operator creates incorrect command line args

https://minio-zone-0-{0...3}.minio-hl.default.svc.cluster.local/export{0...1}
https://minio-zone-1-{0...3}.minio-hl.default.svc.cluster.local/export{0...1}

It should be

https://minio-zone-0-{0...3}.minio-hl.default.svc.cluster.local/export{0...1}
https://minio-zone-1-{0...3}.minio-hl.default.svc.cluster.local/export{0...3}

@nitisht
Copy link
Contributor

nitisht commented Jul 22, 2020

Patching an existing Tenant did not add new statefulset / pods

@dvaldivia
Copy link
Collaborator Author

@nitisht both issues are fixed now

@nitisht nitisht merged commit f94501c into minio:master Jul 23, 2020
jmontleon added a commit to jmontleon/operator that referenced this pull request Jul 23, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants