Prepare for the addition of new CRD #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you do |
dvaldivia
requested changes
Nov 17, 2023
I though these are just because the codegen version was updated recently and all @cniackz did was run |
|
if I do that along with |
Addressed in last commit, this is fine to merge |
pjuarezd
approved these changes
Nov 20, 2023
* Bump code-generator to v0.28.4 * Add grants for needed bash scripts * execute `make regen-crd` and `make-regen-crd-docs`. * `go mod tidy` all the things Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd
force-pushed
the
auto-generate-crd
branch
from
dda305b to
356e837
Compare
dvaldivia
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
This PR has been created in anticipation of introducing a new CRD
Reason:
Currently, running
./k8s/update-codegen.shdoes not work; it necessitates code changes. If this script is essential for adding new CRDs, it should function properly initially. I suspect that some of the detailed files contain features we no longer support. However, these files were not removed because this script isn't executed frequently enough to automatically generate them.