add proper zone validation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
approved these changes
Jul 25, 2020
jmontleon
pushed a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
👻 simplified tools/tackle-opdev.sh with `make bundle` :bug: `docker-build`, `bundle-build` fixes for docker where `--arch` is invalid :seedling: `make deploy-olm` to run local unpublished changes from source installed with a new bundle. - replicate behavior of installing from OperatorHub giving you better idea of what the CSV, CRDs, RBACs, from the `bundle/` looks like in the cluster rather than just creating a simple deployment or replacing the deployment image. - TL;DR `make podman-build podman-push bundle bundle-build bundle-push` using ttl.sh registry (no auth required) Goal: minimize functional changes and allow for `make bundle` command to work using info from `config/` ```sh diff <(curl -s https://raw.githubusercontent.com/konveyor/tackle2-operator/main/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)') <(curl -s https://raw.githubusercontent.com/kaovilai/tackle2-operator/configmakefile-update/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)') ``` minimal semantic diff when running through https://yamldiff.com/ - `curl https://raw.githubusercontent.com/konveyor/tackle2-operator/main/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)'` - `curl https://raw.githubusercontent.com/kaovilai/tackle2-operator/configmakefile-update/bundle/manifests/konveyor-operator.clusterserviceversion.yaml | yq -P 'sort_keys(..)'` noop `bundle/` changes - side-effect of operator-sdk generate bundle - yaml keys are now sorted from a to z - long string values are broken up into multiple lines - `>+` `|+` no longer has `+` other `bundle/` changes - 🌱 CSV name change: `tackle-operator.v99.0.0` --> `konveyor-operator.v99.0.0` - operator-sdk requires CSV and file names to match the [projectName](https://github.com/konveyor/tackle2-operator/blob/0c18e4fdde3de1ad148dcad9d9eb4ab269ba5b03/PROJECT#L7) - alternative is to change projectName to tackle-operator - Partial requirement of minio#198 - relatedImages in CSV is now generated from manager Env `RELATED_IMAGE_<>` with prefix removed, lowercased: - new relatedImages: - `oauth-proxy` previously not in CSV. - renamed relatedImages: - `tackle-addon` --> `addon-admin` - `tackle-addon-windup` --> `addon-windup` - `tackle-pathfinder` --> `pathfinder` - `tackle-keycloak` --> `keycloak-sso` - `tackle-keycloak-init` --> `keycloak-init` - 🌱 renamed manager Env: - `RELATED_IMAGE_TACKLE_POSTGRES` replaces - `RELATED_IMAGE_KEYCLOAK_DATABASE` - `RELATED_IMAGE_PATHFINDER_DATABASE` - solves ``` WARN[0000] warning: multiple related images with the same image ref, "pathfinder-database", and different names found.The image will only be listed once with an empty name.It is recmmended to either remove the duplicate or use the exact same name. ``` While this is in draft, you may see some deletions in this PR which are a result of outdated config/ and will be resolved before coming out of draft.. Closes minio#201 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.