Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend trivial parity #1988

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

allanrogerr
Copy link
Contributor

Issue summary

In the minio operator console, when creating a tenant, the user is not able to select any different EC Parity than an invalid EC:4 or EC:2.
See #1901 for more details

Test summary

Test 0 - Reproduce issue on master.

  1. As reported by user, attempt to create a tenant with 1 node and 1 drive with 1GiB storage Observe no valid parity EC:0 available
  2. Also observe that if an invalid Resource is specified, then the user navigates away then back to the main create page, the Create button is enabled incorrectly.
  3. Also observe that if multiple parities were selectable using a particular drive/server configuration e.g. 4 nodes, 8 drives (giving EC:8,7,6,5,4,3,2, THEN a 1 node 1 drive configuration were selected that those same parities EC:8,7,6,5,4,3,2 are selectable still, even though they cannot be applied to a 1 node 1 drive configuration.

Fix on recommend-trivial-parity branch
Test 1 - As reported by user, attempt to create a tenant with 1 node and 1 drive with 1GiB storage Observe valid parity EC:0 is now available
Test 2 - Actually create the tenant and validate its storage

Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901901

Fixes: #1901

@allanrogerr allanrogerr force-pushed the recommend-trivial-parity branch from b8aa6f6 to 8492685 Compare February 19, 2024 05:04
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.

@allanrogerr allanrogerr merged commit 0eb342d into minio:master Feb 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator console recommends invalid parity
3 participants