Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check sa before start a job #2024

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 7, 2024

feat: check sa before start a job

guozhi.li added 2 commits March 7, 2024 19:02
check sa before start a job
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from shtripat March 8, 2024 02:00
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that make sense

@cniackz cniackz merged commit baccdf6 into minio:master Mar 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants