-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create job and Watch job status for minioJob #2031
Conversation
Yes, I like this approach. Operation Alias to MC Command function that can translate from: - op: make-bucket
args:
name: memes to: mc mb ALIAS/memes |
Please continue with these changes; they look good to me. Just ensure that you address the lint issues and mark the pull request as ready for testing. After that, we can conduct another round of review. Thank you very much @jiuker 🥳 |
watch the minioJob 1.handle the minioJob 2.check ref tenant 3.check sa 4.create the job 5.generate the status to minioJob according to the intervalJob status watch the job 1.update the intervalJob status
7b6508d
to
d51d09e
Compare
This looks like a useful change // cc @pjuarezd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the changes and works as expected.
Few minor ones.
apply suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
watch the minioJob
1.handle the minioJob
2.check ref tenant
3.check sa
4.create the job
5.generate the status to minioJob according to the intervalJob status
watch the job
1.update the intervalJob status
How to test:
OPERATOR_STS_ENABLED = on
Failed example:
Running example: