Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document TLS Certificates flow with Cert Manager #2079

Merged
merged 45 commits into from
Jun 7, 2024
Merged

Document TLS Certificates flow with Cert Manager #2079

merged 45 commits into from
Jun 7, 2024

Conversation

pjuarezd
Copy link
Member

No description provided.

@pjuarezd pjuarezd force-pushed the cert-manager-flow branch from d4f468d to 23234f6 Compare April 18, 2024 23:10
shtripat
shtripat previously approved these changes Apr 19, 2024
View reviewed changes
@pjuarezd pjuarezd self-assigned this Apr 19, 2024
@cniackz cniackz self-requested a review April 20, 2024 03:41
cniackz
cniackz previously approved these changes Apr 20, 2024
View reviewed changes
@cniackz
Copy link
Contributor

cniackz commented Apr 20, 2024

@pjuarezd, @shtripat and I already approved. However, I noticed the title is marked as 'WIP.' Should we wait for further changes, or should we proceed with merging now? Please let us know and update the title accordingly. By the way, thank you for documenting this for us; it is very helpful already!

@pjuarezd
Copy link
Member Author

@pjuarezd, @shtripat and I already approved. However, I noticed the title is marked as 'WIP.' Should we wait for further changes, or should we proceed with merging now? Please let us know and update the title accordingly. By the way, thank you for documenting this for us; it is very helpful already!

I am missing the KES certificates, but I think is better to merge this one, and will open another for KES.

@pjuarezd pjuarezd changed the title [WIP] Document TLS Certificates flow with Cert Manager Document TLS Certificates flow with Cert Manager Apr 20, 2024
ramondeklein
ramondeklein requested changes Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
docs/cert-manager.md Outdated Show resolved Hide resolved
@pjuarezd pjuarezd dismissed stale reviews from cniackz and shtripat via d23c187 April 22, 2024 16:41
@pjuarezd pjuarezd requested a review from ramondeklein April 22, 2024 16:42
ramondeklein
ramondeklein previously approved these changes Apr 22, 2024
View reviewed changes
@pjuarezd pjuarezd requested review from feorlen and ravindk89 April 22, 2024 18:18
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
allanrogerr
allanrogerr reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
@pjuarezd pjuarezd force-pushed the cert-manager-flow branch from ab25c79 to c2cca55 Compare April 22, 2024 19:25
feorlen
feorlen reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
feorlen
feorlen reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
@feorlen
Copy link
Contributor

feorlen commented Apr 22, 2024

@pjuarezd I edited the instructions, although there are some parts I don't fully understand. Please feel free to correct anything. 😄

feorlen
feorlen reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
feorlen
feorlen reviewed Apr 22, 2024
View reviewed changes
docs/cert-manager.md Outdated Show resolved Hide resolved
@ramondeklein
Copy link
Contributor

Not sure if it's ready for review again. Please mention is we need to review again...

@pjuarezd pjuarezd force-pushed the cert-manager-flow branch from c16f578 to e3da4e6 Compare April 23, 2024 15:52
pjuarezd and others added 8 commits May 28, 2024 10:39
@pjuarezd @shtripat
Update pkg/controller/sts.go
4a457e4 
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
@pjuarezd @shtripat
Update docs/cert-manager.md
fb62f00 
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
3846eac 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
6eedaa5 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
e6a232b 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
c0dac05 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
6d531c2 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd @allanrogerr
Update docs/cert-manager.md
2f28021 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
@pjuarezd pjuarezd force-pushed the cert-manager-flow branch from 33243b4 to 2f28021 Compare May 28, 2024 17:40
@pjuarezd @allanrogerr
Update docs/cert-manager.md
5c47763 
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
allanrogerr
allanrogerr reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still facing this @pjuarezd ...
image

pjuarezd added 3 commits May 28, 2024 17:24
@pjuarezd
no longer needed to restart Operator deployment
f747705 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd
Create CA certificates before issuers
fa785e1 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd
Fix wrong DNS name
1316212 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd force-pushed the cert-manager-flow branch from 908ecde to 1316212 Compare May 29, 2024 01:10
@pjuarezd
Copy link
Member Author

Still facing this @pjuarezd ...

Fixed here 1316212, it was a wrong DNS name

@pjuarezd
Copy link
Member Author

pjuarezd commented Jun 4, 2024

Still facing this @pjuarezd ...

Fixed here 1316212, it was a wrong DNS name

@allanrogerr had a chance to test this? do you have any other insight?

ramondeklein
ramondeklein approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have reviewed the documentation, because I didn't know how to run the scripts in examples/kustomization. I still deploy tenants using Helm...

docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
docs/cert-manager.md Show resolved Hide resolved
examples/kustomization/cert-manager/kustomization.yaml Show resolved Hide resolved
@feorlen
Copy link
Contributor

feorlen commented Jun 6, 2024

I still deploy tenants using Helm...

@ramondeklein If you are interested in trying Kustomize, I have some almost finished docs in this PR: minio/docs#1219
Always helpful to find another person to test procedures 😁

@ramondeklein
Copy link
Contributor

@feorlen Please let me review when you're done. I'll be OOO until Monday, but would be glad to test it...

allanrogerr
allanrogerr approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@pjuarezd pjuarezd merged commit 855d22b into minio:master Jun 7, 2024
30 checks passed
@pjuarezd pjuarezd deleted the cert-manager-flow branch June 7, 2024 23:17
pjuarezd added a commit to pjuarezd/operator that referenced this pull request Jun 9, 2024
@pjuarezd
Add suggestions made on PR minio#2079 for the Cert Manager doc
52d2869 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd mentioned this pull request Jun 9, 2024
Merged
pjuarezd added a commit that referenced this pull request Jun 11, 2024
@pjuarezd
Cert manager doc suggestions (#2154)
45ef52d 
Add suggestions made on PR #2079 for the Cert Manager doc

Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@feorlen feorlen mentioned this pull request Jun 11, 2024
Closed
@djwfyi djwfyi mentioned this pull request Jul 18, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrogerr allanrogerr allanrogerr approved these changes

@ramondeklein ramondeklein ramondeklein approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat left review comments

@ravindk89 ravindk89 Awaiting requested review from ravindk89

@feorlen feorlen Awaiting requested review from feorlen

@cniackz cniackz Awaiting requested review from cniackz

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pjuarezd @cniackz @feorlen @ramondeklein @allanrogerr @harshavardhana @shtripat @ravindk89