Bugfix sidecar credentials validation #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidecar allways return `Missing root credentials in the configuration.` causing tenant to not start on the modification of the tenant configuration secret that sidecar observes * Adds little `Config secret '%s' sync` log line to know when a secret sync event has triggered in sidecar. * Remove `pkg/validator.go` file, it got moved to `sidecar/pkg/validator/validator.go` and this one is no longer needed. * Fix: "Struct Controller has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation." * Run Informer factories in goroutines to do not block the process and proceed to wait for caches to sync. Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
jiuker
previously approved these changes
May 24, 2024
jiuker
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes findings of @twelho in #2056, except that sidecar files are moved now to a new path and the original PR has conflicts. After additional testing found a few more little enhancements we can do:
FIx: On the modification of the tenant configuration secret sidecar allways return
Missing root credentials in the configuration.and exits, causing tenant pods to restart.Adds little
Config secret '%s' synclog line to know when a secret sync event has triggered in sidecar.Remove
pkg/validator.gofile, it got moved tosidecar/pkg/validator/validator.goand this one is no longer needed.Fix: "Struct Controller has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation."
Run Informer factories in goroutines to do not block the process and proceed to wait for caches to sync.