-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tenant PodInformer for Tenant Status and remove recurrent job #2150
Fix Tenant PodInformer for Tenant Status and remove recurrent job #2150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement too to remove the "v1.min.io/tenant"
literals. Only a single remark about a function that implies to do more than it can and inlining it may be a better alternative.
this might need some more work, shared findings with @cesnietor wiating for his opinion before merge |
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
All good now, tested and doubled tested |
for documenting purposes: |
Use PodInformer to Update Tenant status.
Previous code had both an informer and a recurrent job (every 3 min) but it wasn't working great so this changes so that it updates the tenant status every time there's a change on the pods.
Before informer was reacting on all pods and then filtering them when handling the event, now it only reacts on pods that match the label selector.
Changes:
v1.min.io/tenant
withminiov2.TenantLabel
Test Steps