-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support command for minioJob #2151
Conversation
support commands for minioJob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified.
One suggestion.
suggestion
I'm fine with the code, but isn't it a security risk to allow running commands as any service account? If you know the name of a privileged service account, then you can run any command using that account (if you're entitled to submit Minio jobs). |
@dvaldivia @harshavardhana What's your opinion? You can also submit jobs that issue |
feat: support command for minioJob
how to test: