Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split sidecar to have it's own goreleaser.yml #2153

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Jun 7, 2024

No description provided.

@pjuarezd pjuarezd force-pushed the prepare-sidecar-release branch from 9a27d1d to 2cc056c Compare June 7, 2024 23:24
@pjuarezd pjuarezd force-pushed the prepare-sidecar-release branch from 52797dc to 4779948 Compare June 8, 2024 01:31
pjuarezd added 3 commits June 7, 2024 18:46
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
harshavardhana
harshavardhana previously approved these changes Jun 8, 2024
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
dvaldivia
dvaldivia previously approved these changes Jun 8, 2024
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd requested a review from dvaldivia June 8, 2024 19:44
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would help to see a description in each PR that explains (briefly) why the PR was made or a link to an issue that it is suppose to solve.

@pjuarezd
Copy link
Member Author

LGTM, but it would help to see a description in each PR that explains (briefly) why the PR was made or a link to an issue that it is suppose to solve.

It's just that Sidecar and Operator images are not going to be released allways at the same time

@pjuarezd pjuarezd merged commit 37194d9 into minio:master Jun 10, 2024
31 checks passed
@pjuarezd pjuarezd deleted the prepare-sidecar-release branch June 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants