Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 1 second delay between pod health checks requeue #2163

Merged

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Jun 13, 2024

Right now is running too often causing a lot of logs in Operator too quick, usually MinIO will take some seconds to restart.

Operator showing the following error tens of time per second

I0613 16:45:56.643423       1 monitoring.go:123] 'tenant-1/myminio' Failed to get cluster health: Get "https://minio.tenant-1.svc.cluster.local/minio/health/cluster": dial tcp 10.96.194.110:443: i/o timeout

Right now is running too often causing a lot of logs in Operator, usually MinIO will take some seconds to restart.

Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd requested a review from cesnietor June 13, 2024 01:58
@pjuarezd pjuarezd self-assigned this Jun 13, 2024
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative options (not sure if that would be better):

  • Use exponential back-off
  • Reduce logging after a while

@pjuarezd
Copy link
Member Author

Alternative options (not sure if that would be better):

  • Use exponential back-off
  • Reduce logging after a while

this queue already have a rate limiter

healthCheckQueue: queue.NewRateLimitingQueueWithConfig(MinIOControllerRateLimiter(), queue.RateLimitingQueueConfig{Name: "TenantsHealth"}),

func MinIOControllerRateLimiter() queue.RateLimiter {
return queue.NewMaxOfRateLimiter(
queue.NewItemExponentialFailureRateLimiter(5*time.Second, 60*time.Second),
// 10 qps, 100 bucket size. This is only for retry speed and its only the overall factor (not per item)
&queue.BucketRateLimiter{Limiter: rate.NewLimiter(rate.Limit(10), 100)},
)
}

@pjuarezd pjuarezd merged commit cabe56d into minio:master Jun 13, 2024
31 checks passed
@pjuarezd pjuarezd deleted the health-chech-reqeue-delayed-1-second branch June 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants