-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readiness Endpoint support #2183
Conversation
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
gofumpt it please |
Linting is complaining
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evel=warning msg="[linters_context] running gomodguard failed: unable to parse module file go.mod: go.mod:3: invalid go version '1.22.0': must match format 1.23\ngo.mod:5: unknown directive: toolchain: if you are not using go modules it is suggested to disable this linter"
@cesnietor I don't think that is an error, it's simply a warning |
Sidecar is still complaining on the import
|
all lint problems taken care of @cesnietor @pjuarezd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this feature to the V6.0 release notes in pr #2141 ?
Co-authored-by: Cesar N. <11819101+cesnietor@users.noreply.github.com>
This PR introduces a readiness endpoint for the MinIO Tenant via the sidecar container. This endpoint is used to check
if the MinIO Tenant is ready to serve requests. The readiness endpoint is exposed at the
/ready
path.The intention is to prevent kubernetes from routing traffic to a MinIO pod if it's not ready, while allowing MinIO pods
to talk to each other via the headless service with the
publishNotReady
flag set totrue
.If MinIO returns
403
status, we deem that MinIO ready to receive trafficThis also removes
MINIO_OPERATOR_VERSION
to prevent rolling restarts on operator upgradesWith this change pods that are not "online" should not shown as ready